Update: Log the unhandled error status code in HTTP probing #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennypradipta
requested review from
nicnocquee,
sapiderman,
haricnugraha and
kevin-hyperjump
kevinhermawan
approved these changes
Nov 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
==========================================
- Coverage 61.44% 61.18% -0.27%
==========================================
Files 106 106
Lines 3136 3138 +2
Branches 535 535
==========================================
- Hits 1927 1920 -7
- Misses 1031 1035 +4
- Partials 178 183 +5
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monika Pull Request (PR)
What feature/issue does this PR add
This PR fixes #1171
How did you implement / how did you fix it
Add logger in unhandled error status code
Rename the function to be more "human"
How to test
Try to fail your probes